Skip to content

Upgrade go.viam.com/rdk to v0.126.1#189

Merged
NickPPC merged 1 commit into
mainfrom
worktree-rdk-upgrade
May 19, 2026
Merged

Upgrade go.viam.com/rdk to v0.126.1#189
NickPPC merged 1 commit into
mainfrom
worktree-rdk-upgrade

Conversation

@NickPPC
Copy link
Copy Markdown
Member

@NickPPC NickPPC commented May 18, 2026

Summary

Upgrades go.viam.com/rdk from v0.119.2 to v0.126.1 (latest stable) and adapts the customer detector to the new vision API.

Changes

  • go.mod / go.sum: bump go.viam.com/rdk v0.119.2 → v0.126.1, go.viam.com/api v0.1.533 → v0.1.545, go.viam.com/utils v0.4.13 → v0.4.19, plus transitive bumps (grpc, gonum, pion/mediadevices, etc.) from go mod tidy.
  • customerdetector/customerdetector.go: vision.Service.Detections now takes *camera.NamedImage instead of image.Image. Wrap the captured frame with camera.NamedImageFromImage before invoking the detector; add go.viam.com/rdk/data import for data.Annotations{}.
  • cup_pickup.go: incidental gofmt -s whitespace alignment in a var (...) block (no semantic change).

Compatibility note

The Detections signature change is purely client-side. The underlying GetDetectionsRequest gRPC payload (Name, Image bytes, Width, Height, MimeType, Extra) is unchanged between v0.119.2 and v0.126.1, so the vision-service module running on the machine does not need to be upgraded.

Testing

  • make — builds clean
  • make test — all package tests pass (beanjamin, multiposesexecutionswitch)
  • go vet ./... — clean

Note: make lint cannot run locally because the installed golangci-lint is v1 but the repo config is v2 — pre-existing toolchain issue unrelated to this change. CI will run the right version.

Claude Code Prompts Used

  • "Hi Claude, can you upgrade the rdk dependency to the latest stable version?"
  • "Given the change to the vis.Detections signature do I need to also upgrade the code for the vision service? Will I face some incompatibility?"
  • "please push and open a PR"

🤖 Generated with Claude Code

@NickPPC NickPPC requested a review from a team May 18, 2026 23:11
Adapt to the new vision API in customerdetector: vis.Detections now takes
*camera.NamedImage instead of image.Image. Wrap the captured frame with
camera.NamedImageFromImage before invoking the detector.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@NickPPC NickPPC force-pushed the worktree-rdk-upgrade branch from 01b82e7 to 67330c1 Compare May 18, 2026 23:14
@NickPPC NickPPC merged commit 9ec16f3 into main May 19, 2026
4 checks passed
@NickPPC NickPPC deleted the worktree-rdk-upgrade branch May 19, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant